[PATCH] ctdb/pmda: Fix metric identifiers
ddiss at suse.de
Sun Mar 23 13:39:45 MDT 2014
On Fri, 21 Mar 2014 13:41:36 -0700
Jeremy Allison <jra at samba.org> wrote:
> On Thu, Mar 20, 2014 at 02:23:01PM +0100, David Disseldorp wrote:
> > The commit "pmda: Use upstream assigned PCP domain id" updated the
> > Performance Metrics Namespace (pmns) file, without changing the
> > corresponding metric identifiers used by the agent.
> > This change fixes the agent metric identifier values to match the pmns
> > definitions.
> > Signed-off-by: David Disseldorp <ddiss at samba.org>
> LGTM. Pushed.
> Any chance we can change the numbers to
> #define'd constants in future ? Does anyone really care ?
The separate pmns definitions would still be necessary, but I agree,
#def's would be a bit cleaner here.
More information about the samba-technical