master4-dcerpc-ok

[Andrew Bartlett]

On Wed, 2014-03-19 at 15:53 +1300, Andrew Bartlett wrote:
> On Tue, 2014-03-18 at 16:38 +0100, Stefan (metze) Metzmacher wrote:
> > Am 12.03.2014 17:12, schrieb Stefan (metze) Metzmacher:
> > > Hi,
> > > 
> > > here's new stuff in my
> > > https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-dcerpc-ok
> > > branch.
> > > 
> > > Please review and push:-)
> > 
> > There're some updates in this branch, which also fix the regressions
> > Andrew found.
> 
> Any idea why didn't our tests find that regression?
> 
> Andrew Bartlett
> 

305f97ceb5bc2c00d2e1725a3e45482d4e59bac2
 s4:libcli/clilsa: make use of dcerpc_pipe_connect_b()

Can you explain what calling this over and over with the same binding
the "connection" does?

	status = dcerpc_binding_set_pointer_option(binding,
+						   "connection",
+						   struct smbXcli_conn,
+						   cli->transport->conn);
+	if (!NT_STATUS_IS_OK(status)) {
+		talloc_free(lsa);
+		return status;
+	}
+
+	status = dcerpc_binding_set_pointer_option(binding,
+						   "connection",
+						   struct smbXcli_session,
+						   cli->session->smbXcli);
+	if (!NT_STATUS_IS_OK(status)) {
+		talloc_free(lsa);
+		return status;
+	}
+
+	status = dcerpc_binding_set_pointer_option(binding,
+						   "connection",
+						   struct smbXcli_tcon,
+						   lsa->ipc_tree->smbXcli);

There is a similar pattern in 04061bb3bf6d63cfa76028a6c878df9d3fe7af2c
s4:torture/samba3rpc: split out pipe_bind_smbXcli() and go via
dcerpc_pipe_connect_b()

Otherwise, I'm quite happy with the series.  Next I'll test the AD
password lockout stuff using this branch rather than your hacks. 

Thanks,

Andrew Bartlett 

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba