[PATCH] more FSRVP & additionally HRESULT error

Stefan (metze) Metzmacher metze at samba.org
Tue Mar 18 01:04:10 MDT 2014


Hi Noel,

> ok added full descriptions for existing const defines that had only the
> short ( e.g. name of the const ) definition but were missing the full
> description and also added both short and full descriptions for the
> remaining, see top commit of
> http://cgit.freedesktop.org/~noelp/noelp-samba/log/?h=heave_in_ntstatus

Great thanks!

Can you also publish the script you used?
Similar to
https://git.samba.org/?p=samba.git;a=blob;f=source4/scripting/bin/w32err_code.py;h=4ca6413e942

The same applies to the HRESULT generation.

It would be also good if you could split
http://cgit.freedesktop.org/~noelp/noelp-samba/commit/?h=heave_in_hresult-v2&id=be6cc634b31777044e4c7d5c93d0124bc41ad1b7
to that the libcli/util/ changes are in there own commit.
The rest should be combined with
http://cgit.freedesktop.org/~noelp/noelp-samba/commit/?h=heave_in_hresult-v2&id=d0e9479324893f35b52012d7bddb5f244471a94a

Thanks!
metze


More information about the samba-technical mailing list