tstream dcerpc regression

[Stefan (metze) Metzmacher]

Hi Andrew,

here're two commits which fix some of this (maybe everything)

https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=0b51cda3dbe45e6a299dd820bb64719b3d9939ef
https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=e71e321f84d00128945570a6a74c00530f09e987

I'll rework them later, but they may allow you to make more progress on
your tests.

metze

Am 15.03.2014 12:28, schrieb Andrew Bartlett:
> Metze,
> 
> While trying to add the tests for the lockout code that we discussed in
> our private thread, I came across this regression when talking to a
> Windows 2008R2 domain controller, particularly around SMB Signing. 
> 
> Per the bisect I've run, the regression is in 
> d230f73e97f6dc625e1111a676d1504ac00fb28f is the first bad commit
> commit d230f73e97f6dc625e1111a676d1504ac00fb28f
> Author: Gregor Beck <gbeck at sernet.de>
> Date:   Mon Sep 16 11:51:44 2013 +0200
> 
>     s4:librpc: use tstream_smbXcli_np in dcerpc_smb.c
>     
>     Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
>     
>     Signed-off-by: Gregor Beck <gbeck at sernet.de>
>     Signed-off-by: Stefan Metzmacher <metze at samba.org>
>     Reviewed-by: Stefan Metzmacher <metze at samba.org>
>     Reviewed-by: Andreas Schneider <asn at samba.org>
> 
> There may also be a second regression, as on the branch with the lockout
> code, I get a even more fatal error.  See below for the error logs.
> 
> Can you take a look please?
> 
> Thanks,
> 
> Andrew Bartlett
> 
> (at the indicated commit)
> + bin/smbtorture win2008r2-11.ad.ruth.wgtn.cat-it.co.nz
> rpc.samr.passwords.lockout --realm=AD.RUTH.WGTN.CAT-IT.CO.NZ
> -Uadministrator%penguin12# -d1 -WAD
> smbtorture 4.2.0pre1-DEVELOPERBUILD
> Using seed 1394882163
> time: 2014-03-16 00:16:03.074516
> progress: 1
> We still need to perform a DsAddEntry() so that we can create the
> CN=NTDS Settings container.
> test: samr.lockout
> time: 2014-03-16 00:16:03.408306
> Testing samr_Connect
> Testing samr_Connect2
> Testing samr_Connect3
> Testing samr_Connect4
> Testing samr_Connect5
> Testing LookupDomain(AD)
> Testing GetDomPwInfo with name AD
> Testing GetDomPwInfo with name \\WIN2008R2-11.AD.RUTH.WGTN.CAT-IT.CO.NZ
> Testing GetDomPwInfo with name \\__NONAME__
> Testing GetDomPwInfo with name \\Builtin
> Testing OpenDomain of S-1-5-21-1597677697-3903218833-1822848277
> Testing CreateUser2(samrtorturetest, 0x10)
> smb_signing_check_pdu: out of seq. seq num 15 matches. We were expecting
> seq 17
> smb_signing_good: BAD SIG: seq 17
> tstream_smbXcli_np_destructor: cli_close failed on pipe netlogon. Error
> was NT_STATUS_ACCESS_DENIED
> Failed to bind to uuid 12345678-1234-abcd-ef00-01234567cffb for
> ncacn_np:win2008r2-11.ad.ruth.wgtn.cat-it.co.nz[\pipe\netlogon,sign]
> NT_STATUS_UNEXPECTED_NETWORK_ERROR
> WARNING!: ../source4/torture/rpc/samr.c:3196:
> dcerpc_pipe_connect_b(tctx, p, b, &ndr_table_netlogon, credentials,
> tctx->ev, tctx->lp_ctx) was NT_STATUS_UNEXPECTED_NETWORK_ERROR, expected
> NT_STATUS_OK: failed to bind to netlogon
> WARNING!: lockout test failed
> 
> (on metze-master4-abartlet2)
> smbtorture 4.2.0pre1-DEVELOPERBUILD
> Using seed 1394882746
> time: 2014-03-16 00:25:46.947129
> progress: 1
> Failed to bind to uuid e3514235-4b06-11d1-ab04-00c04fc2dcd2 for
> e3514235-4b06-11d1-ab04-00c04fc2dcd2 at ncacn_ip_tcp:win2008r2-11.ad.ruth.wgtn.cat-it.co.nz[49155,seal,assoc_group_id=0x000027d6] NT_STATUS_UNSUCCESSFUL
> Domain join failed - Connection to DRSUAPI pipe of PDC of domain 'AD'
> failed: NT_STATUS_UNSUCCESSFUL
> test: samr.lockout
> time: 2014-03-16 00:25:47.112182
> time: 2014-03-16 00:25:47.112203
> failure: samr.lockout [
> Setup failed: ../source4/torture/rpc/rpc.c:187: Failed to join as BDC
> ]
> smb_signing_check_pdu: out of seq. seq num 31 matches. We were expecting
> seq 33
> smb_signing_good: BAD SIG: seq 33
> tstream_smbXcli_np_destructor: cli_close failed on pipe samr. Error was
> NT_STATUS_ACCESS_DENIED
>