[PATCH] Make loadparm

Andrew Bartlett abartlet at samba.org
Wed Mar 12 21:08:14 MDT 2014


I'm really impressed by the patches you just showed me at 

The only issues I see are that in:

http://git.catalyst.net.nz/gitweb?p=samba.git;a=commitdiff;h=cfb8729e4444ae11fcc5edea8c19266e92eeb98f you copy loadparm_context into source3/param/loadparm.c.  The commit 
http://git.catalyst.net.nz/gitweb?p=samba.git;a=commitdiff;h=3ed675ca7eb2a2ce62a8af78fe94ccbeeb01cf5b needs to be squashed with it, and a longer explanation of why this is really important added. 

http://git.catalyst.net.nz/gitweb?p=samba.git;a=commitdiff;h=abdb3c221a42afc081af42a80489e031b21e5e67 we need to be more careful about the talloc parent used for the string list.  It shows that we really need to sort out which long-term talloc parent global variables are hung off - I think that we have no choice but to initialise lp_ctx->globals->ctx to lp_ctx->globals, so we can use it just like we use Globals.ctx, and therefore remove this confusion. 

we need to avoid putting that extern struct directly into a C file, it
should go into a header.  A second patch to expand NUMPARAMETERS to be a
normal function call would be worthwhile also. 

We should also be able to avoid the need to make the enums non-static.
Would moving the .special functions into param_table.c fix that (they
could then be non-static too!)

Other than that, I'm very pleased!

Aside from these small comments, easily sorted out, can I get comments,
thoughts and perhaps a second team reviewer for this?


Andrew Bartlett
Andrew Bartlett
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list