change --picky-developer into --non-picky-developer

[Stefan (metze) Metzmacher]

Am 12.03.2014 20:09, schrieb Jeremy Allison:
> On Wed, Mar 12, 2014 at 05:22:36PM +0100, Stefan (metze) Metzmacher wrote:
>> Hi,
>>
>> I've created a patchset that does fix a lot of compiler warnings
>> and lets --enable-developer imply -Werror by default.
>>
>> This uses a allow_warnings argument to SAMBA_SUBSYSTEM/LIBRARY/MODULE,
>> which is False by default. Which means autobuild will protect us
>> from having new warnings introduced.
>>
>> If a developer has a compiler that generates more warnings
>> (as the gcc from ubuntu 10.04 or 12.04) he needs
>> --non-picky-developer in order to avoid -Werror.
>>
>> Overtime we can aim to add more -W* flags and
>> reduce the number of allow_warnings=True usages.
>>
>> Please review and push
>> https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-picky
> 
> Oooh. I *love* this. Once we get warning-free
> there's no going back :-).

That's the idea:-)

I've uploaded a fixed version of
https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=6f96d68a8e9201fc33a1c80ff313817c779d1bf9

I now use this in get_codepoint():

+       if (ret == (size_t) -1) {
+               return (unsigned int)-1;
+       }

instead of

+       if (ret == (size_t) -1) {
+               return 0;
+       }

This fixes TDB_NO_FSYNC=1 buildnice make -j test TESTS=samba4.local.iconv

metze