[PATCH 5/5] docs-xml:wscript_build: avoid always=True for the smbdotconf/parameters.all.xml

Andrew Bartlett abartlet at samba.org
Wed Mar 12 14:30:22 MDT 2014

On Wed, 2014-03-12 at 17:08 +0100, Stefan (metze) Metzmacher wrote:
> Am 18.02.2014 01:52, schrieb Stefan (metze) Metzmacher:
> > Hi,
> > 
> > here's a small patch to our autobuild script, which lets it use the
> > --force-rebase option of git rebase.
> > 
> > This forces the git committer to be rewritten for all commits not just
> > the top
> > commit.
> I've added a few more commits and someone review and push them?
> They also should fix make test FAIL_IMMEDIATELY=1 with segfaults
> and other strange errors.

Please hold off on the wscript change for parameters.all.xml for now.
The part that isn't encoded in dependencies, like build_options.c and
version.h is the WAF internal variables that are used by the python
script running as the generator.  There is a way to include these

The impact (and example I'm concerned about) would be that re-running
configure with a different prefix would not update the docs and would
then fail the docs.py test, as well as failing a future build where we
use these defaults directly in the code. 


Andrew Bartlett

Andrew Bartlett
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list