[PATCH] more FSRVP & additionally HRESULT error

Noel Power nopower at suse.com
Wed Mar 12 09:40:10 MDT 2014

Hi Metze

On 12/03/14 12:24, Stefan (metze) Metzmacher wrote:
> Hi Noel,
> The patch probably is too large to mail so please see (top 2 commits) on
> branch
> http://cgit.freedesktop.org/~noelp/noelp-samba/log/?h=heave_in_hresult
> Looks very interesting!
> Can you add a HRESULT structure similar to NTSTATUS and WERROR,
> so that this is not mixed with uint32 values?
sure please see next cut of this patch,
> It would also be good to add some prefix to the constants, maybe
> HRES_, similar to WERR_?
done also, see above. Also I changed win_errstr ->
get_friendly_werror_msg ( seems I picked the least descriptive one
initially )
> While your're doing script magic would it be possible that you
> autogenerate the
> ntstatus values, we've already done this for WERROR, but we're still
> missing some
> NTSTATUS codes.
Ok, I will try to do this



More information about the samba-technical mailing list