[PATCH] Version 2: Patchset for bug #10344 - SessionLogoff on a signed connection with an outstanding notify request crashes smbd.

Stefan (metze) Metzmacher metze at samba.org
Wed Mar 12 09:30:18 MDT 2014

Am 11.03.2014 22:59, schrieb Jeremy Allison:
> On Tue, Mar 11, 2014 at 01:59:08PM -0700, Jeremy Allison wrote:
>> CONCLUSION (if anyone actually gets down as far as this :-).
>> ------------------------------------------------------------
>> I agree on tmp1.diff and tmp2.diff, with the 'Signed-off-by'
>> change mentioned above.
>> I hate it, but the tevent_queue_wait_send() already exists
>> and is in use inside our code, and even though I think my
>> code is easier to understand people can disagree, so in
>> the interests of not adding extra API's I'm willing to accept
>> metze's fix in place of mine.
>> I also think (at least for the smb2_sesssetup.c
>> and smb2_tcon.c changes that we should change the
>> 'Signed-off-by' lines to include both Metze and
>> myself, as this has been a herculean effort from
>> both of us.
> Here is the proposed patchset for master. Even
> though I like my API better, I recognise when it's
> a reinvention of what is already there :-).


> Metze, if you're OK with this I'll push to
> master and work on back-ports for 4.1.x,
> 4.0.x for the bug report.

Here's an updated version I changed the authorship to you for 2 commits
and added Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
and Signed-off-by: Stefan Metzmacher <metze at samba.org>
to the commits we both modified.

For the backports we need to copy tevent_queue_wait_* to
something like smbd_queue_wait_*, as it was recently added in
tevent-0.9.20 and not available in v4-0-test and v4-1-test.
In order to make it easier for packagers I'd say that would
should not require a newer tevent version there.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: tmp.diff
Type: text/x-diff
Size: 29384 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140312/53921857/attachment.diff>

More information about the samba-technical mailing list