[PATCH] Use talloc in source3 loadparm, make more handlers common

[Andrew Bartlett]

On Mon, 2014-03-10 at 16:46 +0100, Andreas Schneider wrote:
> On Monday 10 March 2014 14:36:23 Andrew Bartlett wrote:
> > On Wed, 2014-02-26 at 14:14 +0100, Andreas Schneider wrote:
> > > On Monday 24 February 2014 17:46:52 you wrote:
> > > > Now that much of loadparm is generated and made regular, Garming's
> > > > attention has turned to the requested task of merging common code.  In
> > > > particular, there is a strong desire to undo the #include of
> > > > param_table.c, and these steps are all critical to that goal.
> > > > 
> > > > The patch series starts with a simple talloc -> malloc conversion, and
> > > > later patches construct an appropriate talloc tree.  Many other small
> > > > changes are needed or desired along the way.
> > > > 
> > > > The general approach is to use the s3_fns hook to handle the special
> > > > cases where the source3 code does something different, and to then
> > > > slowly eliminate these hooks as even more code becomes common.
> > > > 
> > > > The patch series starts here:
> > > > 
> > > > https://gerrit.sernet.de/97
> > > > 
> > > > https://gerrit.sernet.de/#/q/status:open+project:samba+branch:master+top
> > > > ic:l oadparm-talloc-polish,n,z
> > > 
> > > I've reviewed them in Gerrit. There are function were I think we should
> > > remove them completely and use talloc and talloc pools.
> > 
> > Updated patches are in gerrit.
> > 
> > As far as I can see, the concerns raised in your earlier review on this
> > code in gerrit have been addressed, and we now have patch extending the
> > successful docs.py testsuite to confirm values can be correctly set.
> 
> What about the idea to use a talloc_pool() for Globals.ctx for all 
> allocations? So we could get rid of string_init() and string_free().

A talloc_pool() is used for Globals.ctx.  What isn't done is use of the
talloc hierarchy to free memory, yet:  with a few exceptions, it is
still treated like malloc, to avoid changing too many semantics at
once. 

This is all one-step-at-a-time stuff, which is why it is a little
tedious. 

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba