[PATCHv2] smbreadline: switch to new-style readline typedef

Jeremy Allison jra at samba.org
Fri Mar 7 13:16:43 MST 2014


On Thu, Mar 06, 2014 at 06:57:40PM -0300, Gustavo Zacarias wrote:
> Function, CPFunction, CPPFunction and VFunction typedefs are considered
> old-style (deprecated) starting from readline 4.2 (circa 2001).
> Compatibility typedefs have been in place up to readline 6.2 but were
> removed with the 6.3 release thus causing builds to break.
> Switch to the new-style specific prototyped typedef.
> 
> Return value is unused so the callback should still be void (see
> readline/input.c around line 456 in version 6.3).
> 
> Signed-off-by: Gustavo Zacarias <gustavo at zacarias.com.ar>

Reviewed-by: Jeremy Allison <jra at samba.org>

Can I get a second Team reviewer ?

Thanks,

	Jeremy.


More information about the samba-technical mailing list