[PATCH] Support 52 byte DsBindInfo (Win2k12)

[Andrew Bartlett]

On Mon, 2014-03-03 at 22:20 -0700, Bob Ziuchkovski wrote:
> On Mon, 2014-03-03 at 14:57 +1300, Andrew Bartlett wrote:
> > On Sat, 2014-03-01 at 00:46 -0700, Bob Ziuchkovski wrote:
> > > Hi,
> > > 
> > > I'm new to this list but wanted to submit a patch for the issue outlined
> > > here: https://lists.samba.org/archive/samba/2013-November/176722.html
> > > 
> > > This patch adds support for the additional 4 byte field sent by Win2k12
> > > during the bind operation.  It is referred to as 'dwExtCaps' in MS-DRSR
> > > (Section 5.39).
> > > 
> > > With this patch, I can join Samba4 trunk to my Win2k12 R2 test domain
> > > using Win2k8 R2 functional level.
> > 
> > Thank you so much for looking into this!  These small things have been
> > causing trouble for our users for a long time, and it is great that we
> > now have a patch, particularly such a simple one.
> > 
> > Can you add your signed-off-by line to it, and then I'll ask Metze if he
> > can review it.  I'll find time later today to aim this at my 2012 domain
> > here.
> > 
> > https://wiki.samba.org/index.php/CodeReview
> > 
> No problem.  Attached is the patch with my signed-off tag.
> 
> I have only tested joining against a 2012 R2 DC running in 2008 R2
> functional level.  I didn't try joining against 2012 or 2012 R2
> functional level.

Metze,

Can you please add your review to this?  I've tested it with my 2012R2
setup, and while I don't get full success (due to it being in 2012R2
functional level), it certainly moves past this point, and I trust Bob's
testing with he 2008R2 level DC.  It also does not change things with
2008R2. 

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba