[PATCH] samba-tool dbcheck: handle missing objectClass

Andrew Bartlett abartlet at samba.org
Tue Mar 4 18:27:42 MST 2014

On Wed, 2014-03-05 at 00:46 +0100, Stefan (metze) Metzmacher wrote:
> Am 02.03.2014 22:18, schrieb Andrew Bartlett:
> > On Sat, 2014-03-01 at 07:49 +1300, Andrew Bartlett wrote:
> >> On Fri, 2014-02-28 at 14:49 +0100, Stefan (metze) Metzmacher wrote:
> >>> Hi Andrew,
> >>>
> >>> please see my inline comments.
> >>
> >> Thanks, I can fix that up.  Any comments as to the concept?  Do you
> >> think this is a valid check?
> > 
> > Corrected patches attached.  Additionally, I think we probably need to
> > add a similar check to dbcheck, and we still need to work out if this is
> > actually the cause of the issue Felix is seeing, or just similar bug. 
> > 
> > Please review!
> There're some really long ldb_debug_set() lines, please
> add some newlines there.


> You also still use DEBUG(0, and ldb_asprintf_errstring in some places,
> shouldn't we use ldb_debug_set() in most cases?

I think there are cases for both, ldb_debug_set() should generally only
be used where we think the error might not be logged elsewhere, and for
cases that can not be externally triggered by less-privileged

Otherwise, returning the error to the caller that issued the operation
to deal with seems the right thing to do. 

> The rest looks good.

Please review.  Also included is another patch to skip another stored
provision dump from being shipped in the source tarball. 

Felix:  Any news on testing this with a genuinely corrupted network?


Andrew Bartlett
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-dsdb-Ensure-to-sort-replPropertyMetaData-as-UNSIGNED.patch
Type: text/x-patch
Size: 2250 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140305/f2f07202/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-dsdb-Further-assert-that-we-always-have-an-objectCla.patch
Type: text/x-patch
Size: 9819 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140305/f2f07202/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-build-Exclude-source4-selftest-provisions-release-4-.patch
Type: text/x-patch
Size: 988 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140305/f2f07202/attachment-0002.bin>

More information about the samba-technical mailing list