[PATCH] samba-tool dbcheck: handle missing objectClass

Stefan (metze) Metzmacher metze at samba.org
Tue Mar 4 16:46:29 MST 2014

Am 02.03.2014 22:18, schrieb Andrew Bartlett:
> On Sat, 2014-03-01 at 07:49 +1300, Andrew Bartlett wrote:
>> On Fri, 2014-02-28 at 14:49 +0100, Stefan (metze) Metzmacher wrote:
>>> Hi Andrew,
>>> please see my inline comments.
>> Thanks, I can fix that up.  Any comments as to the concept?  Do you
>> think this is a valid check?
> Corrected patches attached.  Additionally, I think we probably need to
> add a similar check to dbcheck, and we still need to work out if this is
> actually the cause of the issue Felix is seeing, or just similar bug. 
> Please review!

There're some really long ldb_debug_set() lines, please
add some newlines there.

You also still use DEBUG(0, and ldb_asprintf_errstring in some places,
shouldn't we use ldb_debug_set() in most cases?

The rest looks good.


More information about the samba-technical mailing list