"net rpc join" with "security = domain" regression

[Andrew Bartlett]

On Tue, 2014-03-04 at 12:22 +0100, Bjoern Baumbach wrote:
> On 08/05/2013 12:25 PM, Andreas Schneider wrote:
> >        via  3e4ded4 s3-net: use libnetjoin for "net rpc join" newstyle.
> >        via  9cfa625 s3-net: use libnetjoin for "net rpc testjoin".
> >        via  1242ab0 s3:libnet: let the caller truncate the pw in libnet_join_joindomain_rpc_unsecure()
> >        via  d398a12 s3-libnetjoin: move "net rpc oldjoin" to use libnetjoin.
> 
> Hi!
> 
> The quoted set of patches break the "net rpc join" with "security =
> domain". I assume that this is not intended and is to be rated as a bug,
> isn't it?
> 
> Using the commit 3e4ded48bbeacdcd128f3c667cbdd12a3efca312 net says:
> # ./bin/net rpc join -UAdministrator%Passw0rd
> Failed to join domain: Invalid configuration ("realm" set to '', should
> be 'doma.private') and configuration modification was not requested
> Failed to join domain: Invalid configuration ("realm" set to '', should
> be 'doma.private') and configuration modification was not requested
> 
> Using d398a12f7907866189c1b253ca6a40e5454f42a1 the join is working, but
> tells the same "Invalid configuration" issue.
> # ./bin/net rpc join -UAdministrator%Passw0rd
> Failed to join domain: Invalid configuration ("realm" set to '', should
> be 'doma.private') and configuration modification was not requested
> Joined domain DOMA.
> # ./bin/net rpc testjoin
> Join to 'DOMA' is OK
> 
> Using c4d6d75cf48aed7b17728e283581366143fa4233 the join is just "OK".

Can you work out why 'make test' didn't pick this up?

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba