[PATCH] CTDB patches

Martin Schwenke martin at meltin.net
Mon Mar 3 17:23:18 MST 2014

On Mon, 3 Mar 2014 13:12:21 +1100, Amitay Isaacs <amitay at gmail.com>

> Here are some fixes to CTDB that resulted from testing on AIX.

Pushed to autobuild.

Just for the record... and mostly for my own memory...  ;-)

While reviewing the tickle changes I confirmed that CTDB doesn't need to
try to register tickles for LVS connections (single IP,
ctdb->single_ip_vnn).  They're not used on the "takeover node".

* The code path that uses registered tickles on the takeover node is:

  ctdb_do_takeip_callback()/ctdb_do_updateip_callback() ->
  ctdb_announce_vnn_iface() ->

  ctdb_announce_vnn_iface() resets vnn->tcp_array to NULL.

  So ctdb_control_tcp_client(), ctdb_control_tcp_add(),
  ctdb_control_tcp_remove() do not need to check ctdb->single_ip_vnn.

* However, 91.lvs uses:

  kill_tcp_connections_local_only() ->
  ctdb killtcp ->
  ctdb_control_kill_tcp() ->
  ctdb_killtcp_add_connection() ->

  This path obviously needs to keep working for LVS.  It doesn't depend
  on registered connections.  It just kills connections found by

peace & happiness,

More information about the samba-technical mailing list