[PATCH] smbreadline: switch to new-style readline typedef
Gustavo Zacarias
gustavo at zacarias.com.ar
Mon Mar 3 16:51:19 MST 2014
On 03/03/2014 05:57 PM, Jeremy Allison wrote:
> A question - rl_hook_func_t is defined here:
>
> http://www.delorie.com/gnu/docs/readline/rlman_26.html
>
> as 'typedef int rl_hook_func_t (void);'
>
> However, callback is defined in the Samba code as :
> void (*callback)(void).
>
> Should we also update the callback() definitions ?
Incomplete docs :)
The callback is just a pointer to a function, used like this in line 456
of readline-6.3/input.c:
(*rl_event_hook) ();
Any return value is ignored and unassigned, so it's good as it is and
may cause compiler warnings if it's not void.
Regards.
More information about the samba-technical
mailing list