[PATCH] smbd: Fix an uninitialized memory read

Volker Lendecke Volker.Lendecke at SerNet.DE
Mon Mar 3 05:53:28 MST 2014


Hi!

Review would be appreciated.

Thanks,

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
-------------- next part --------------
From 77badbebbdd83d776266e4d737cc2208177f6729 Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl at samba.org>
Date: Mon, 3 Mar 2014 13:49:46 +0100
Subject: [PATCH] smbd: Fix an uninitialized memory read

This might be the reason for a few flaky builds.

Signed-off-by: Volker Lendecke <vl at samba.org>
---
 source3/locking/brlock.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/source3/locking/brlock.c b/source3/locking/brlock.c
index a516b60..4715352 100644
--- a/source3/locking/brlock.c
+++ b/source3/locking/brlock.c
@@ -2085,6 +2085,8 @@ static void brl_get_locks_readonly_parser(TDB_DATA key, TDB_DATA data,
 
 	if ((data.dsize % sizeof(struct lock_struct)) == 1) {
 		br_lock->have_read_oplocks = (data.dptr[data.dsize-1] == 1);
+	} else {
+		br_lock->have_read_oplocks = false;
 	}
 
 	DEBUG(10, ("Got %d bytes, have_read_oplocks: %s\n", (int)data.dsize,
-- 
1.7.9.5



More information about the samba-technical mailing list