[PATCH v2 0/3]: Snapper support

David Disseldorp ddiss at suse.de
Mon Jun 30 06:37:04 MDT 2014

Hi Christof and Jeremy,

On Fri, 27 Jun 2014 14:12:11 -0700, Christof Schmitt wrote:

> > That way, the free functions just become talloc_free(parent).

I'll send through a cleanup patch for this.

> > Plus I think you should look at the changes just
> > pushed to master by Volker and Christof, as I think
> > they may also be relevent in this module too.  
> We should try sharing the common code between the vfs_snapper and
> vfs_shadow_copy2 module. 

I did that initially, but wasn't happy with the result.
I think the best way forward would be to move the path handling into the
generic code path, and then have shadow-copy VFS modules only provide
hooks to convert a @GMT/timewarp path to a snapshot path and vice-versa.

> Another minor comment would be that source3/include/smb.h already
> defines GMT_FORMAT, no need to define it again in the vfs module.

Also fixed with subsequent cleanup patch.

Thanks for the feedback!

More information about the samba-technical mailing list