[PATCH 0/2]: Snapper support

[Jeremy Allison]

On Mon, Jun 23, 2014 at 02:58:04PM +0200, David Disseldorp wrote:
> Snapper[1] is a snapshot management tool for Linux, that offers support
> for the creation and deletion of snapshots on btrfs and ext4
> thin-provisioned LVM volumes.
> 
> This patch-set adds and documents a new vfs_snapper module, which
> exposes snapshots managed by snapper to Windows clients, via the
> FSCTL_SRV_ENUM_SNAPS/FSCTL_GET_SHADOW_COPY_DATA ioctls and the
> @GMT/TWrp path tokens.
> 
> Demonstration video: http://youtu.be/RZq84ONWu1I

OK, David, I think I'm being spectacularly
dense here, but I am reviewing this patchset,
and I can't see how this new module gets called :-(.

Inside source3/modules/vfs_snapper.c you have:

static struct vfs_fn_pointers snapper_fns = {
};

and all functions in there are static. On
compile I get:

../source3/modules/vfs_snapper.c:84:24: warning: ‘snapper_dbus_conn_create’ defined but not used [-Wunused-function]
../source3/modules/vfs_snapper.c:110:13: warning: ‘snapper_dbus_conn_destroy’ defined but not used [-Wunused-function]
../source3/modules/vfs_snapper.c:457:17: warning: ‘snapper_list_snaps_pack’ defined but not used [-Wunused-function]
../source3/modules/vfs_snapper.c:553:13: warning: ‘snapper_snap_array_free’ defined but not used [-Wunused-function]
../source3/modules/vfs_snapper.c:630:17: warning: ‘snapper_list_snaps_unpack’ defined but not used [-Wunused-function]
../source3/modules/vfs_snapper.c:689:17: warning: ‘snapper_snap_path_to_id’ defined but not used [-Wunused-function]
../source3/modules/vfs_snapper.c:744:17: warning: ‘snapper_snap_id_to_path’ defined but not used [-Wunused-function]
../source3/modules/vfs_snapper.c:761:17: warning: ‘snapper_get_conf_call’ defined but not used [-Wunused-function]

How do these functions actually get *called* ?

I'm not getting it :-). Sorry if I'm stupid :-).

Jeremy.