[PATCHES] Convert gencache to dbwrap to enable mutexes

Volker Lendecke Volker.Lendecke at SerNet.DE
Wed Jun 25 06:19:47 MDT 2014


On Wed, Jun 25, 2014 at 02:05:08PM +0200, Michael Adam wrote:
> On 2014-06-25 at 13:35 +0200, Volker Lendecke wrote:
> > On Wed, Jun 25, 2014 at 01:18:27PM +0200, Michael Adam wrote:
> > > This would allow to use mutexes correctly
> > > on gencache_notrans. In order to convert
> > > it to dbwrap, we need to add a means of
> > > using allrecord lock via dbrwap (it does
> > > currently not offer it).
> > 
> > ... and I would try to avoid this. I'm not sure I want to
> > think about implementing an allrecord lock for a ctdb
> > database. I'd rather not go through dbwrap for
> > gencache_notrans if that's the only reason to implement a
> > dbwrap_allrecord_lock.
> 
> Right, but we could of course choose to *not* implement it
> in the dbwrap_ctdb case...
> 
> Independently of the choice whether to do the allrecord
> lock throught ctdb or not, do you think the above change
> to gencache_stabilize (on the tdb level) would make sense?

Sure. But with your freelist patches, do we still need the
wipe_all? This should be a nice test if freelist compaction
actually works as designed :-)

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de


More information about the samba-technical mailing list