CTDB waf build

[Michael Adam]

Ok, I reviewed it, and tested it on my machine.
Looks really good.
I pushed a "ctdb-build" branch into my repo
with my review tags. And a few patches on top
for review...

I also took the liberty to rephrase two commit messages slightly.

But I am currently seeing some problems running autobuild on
sn-devel: There seems to be a problem with '#include "tdb.h"'
on a system w/o system-tdb.

Investigating...

Cheers - Michael

On 2014-06-20 at 10:11 +0200, Michael Adam wrote:
> FYI:
> 
> Looking at / reviewing the updated patchset currently...
> 
> Cheers - Michael
> 
> On 2014-06-19 at 23:05 -0700, Amitay Isaacs wrote:
> > On Thu, Jun 19, 2014 at 8:52 PM, Andrew Bartlett <abartlet at samba.org> wrote:
> > 
> > > On Thu, 2014-06-19 at 21:16 +1200, Andrew Bartlett wrote:
> > > > On Thu, 2014-06-19 at 15:59 +1000, Martin Schwenke wrote:
> > > > > On Wed, 18 Jun 2014 11:12:43 -0700, Amitay Isaacs <amitay at gmail.com>
> > > > > wrote:
> > > > >
> > > > > > Here's the first draft of the migration from autoconf to waf build
> > > for CTDB.
> > > > > >
> > > > > > Currently, CTDB is configured and built separately from Samba
> > > (top-level
> > > > > > build).  The integration of build requires some more work on
> > > lib/util, so
> > > > > > it can be used in CTDB without bringing in too many samba
> > > dependencies.
> > > > > >
> > > > > > Since these changes drop duplicate libraries
> > > (talloc/tevent/tdb/replace), I
> > > > > > am not posting the patches on the mailing list.  The patches are
> > > available
> > > > > > in ctdb-build branch of my samba tree.
> > > > > >
> > > > > >
> > > > > >
> > > http://git.samba.org/?p=amitay/samba.git;a=shortlog;h=refs/heads/ctdb-build
> > > > >
> > > > > Looks good to me.  The only nit is that:
> > > > >
> > > > >     ctdb-mkversion: Support external VERSION specification
> > > > >
> > > > > should go before:
> > > > >
> > > > >     ctdb-build: Add waf build for CTDB
> > > > >
> > > > > Reviewed-by: Martin Schwenke <martin at meltin.net>
> > > > >
> > > > > However, I'm guessing that someone who knows waf should probably review
> > > > > too...  ;-)
> > > >
> > > > It is pretty good, the main comment I would make is not to do this:
> > > >
> > > > +    bld.SAMBA_SUBSYSTEM('ctdb-common',
> > > > +                        source=CTDB_COMMON_SRC,
> > > > +                        includes='include include/internal common .
> > > > lib/util',
> > > > +                        deps='replace popt talloc tevent tdb')
> > > > +
> > > >
> > > > but to instead list the source files in source=, unless there is a
> > > > specific reason not to.  We have been moving away from this style
> > > > elsewhere in the code-base.
> > >
> > > Also, here is one more duplicate file.
> > >
> > > Andrew Bartlett
> > >
> > >
> > Thanks Andrew.  I have updated the wscript file by removing the
> > intermediate variables.
> > 
> > Updated patches are in ctdb-build branch.
> > 
> > 
> > https://git.samba.org/?p=amitay/samba.git;a=shortlog;h=refs/heads/ctdb-build
> > 
> > Amitay.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140620/a6e25b76/attachment.pgp>