[PATCH 31/37] param: add failure case for loadparm_init_s3
abartlet at samba.org
abartlet at samba.org
Fri Jun 20 05:47:53 MDT 2014
From: Garming Sam <garming at catalyst.net.nz>
It allocates memory, so it should be possible for it to fail.
Change-Id: Ib24f9718fb88790de23b78435866b9e79fe8c705
Signed-off-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
---
source3/param/loadparm.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/source3/param/loadparm.c b/source3/param/loadparm.c
index d5c1e07..946920f 100644
--- a/source3/param/loadparm.c
+++ b/source3/param/loadparm.c
@@ -2648,6 +2648,12 @@ bool lp_do_parameter(int snum, const char *pszParmName, const char *pszParmValue
if (parm_table[parmnum].special) {
struct loadparm_context *lp_ctx = loadparm_init_s3(frame,
loadparm_s3_helpers());
+ if (lp_ctx == NULL) {
+ DEBUG(0, ("loadparm_init_s3 failed\n"));
+ TALLOC_FREE(frame);
+ return false;
+ }
+
lp_ctx->sDefault = &sDefault;
lp_ctx->services = ServicePtrs;
lp_ctx->bInGlobalSection = bInGlobalSection;
--
1.9.3
More information about the samba-technical
mailing list