[PATCH 04/11] torture: convert raw.mux to use torture_assert() macros
Andrew Bartlett
abartlet at samba.org
Fri Jun 20 04:39:19 MDT 2014
On Thu, 2014-06-19 at 20:58 +0200, Michael Wood wrote:
> Hi
>
> Sorry about bad quoting. My phone doesn't handle it well.
> > @@ -108,8 +108,8 @@ static bool test_mux_open(struct torture_context
> *tctx, struct smbcli_state *cli
> >
> > d = timeval_elapsed(&tv);
> > if (d > 0.25) {
> > - printf("bad timeout for async conflict - %.2f should be
> <0.25\n", d);
> > - ret = false;
> > + torture_comment(tctx, "bad timeout after cancel - %.2f
> should be <0.25\n", d);
> > + torture_assert(tctx, d <= 0.25, "bad timeout after
> cancel");
> > } else {
> > printf("async open delay %.2f\n", d);
> > }
>
> Is this right? You've changed the message from "async conflict" to
> "cancel".
Well spotted, thanks! Fixed in the revised patch set.
Andrew Bartlett
--
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical
mailing list