CTDB waf build

Amitay Isaacs amitay at gmail.com
Fri Jun 20 00:05:02 MDT 2014


On Thu, Jun 19, 2014 at 8:52 PM, Andrew Bartlett <abartlet at samba.org> wrote:

> On Thu, 2014-06-19 at 21:16 +1200, Andrew Bartlett wrote:
> > On Thu, 2014-06-19 at 15:59 +1000, Martin Schwenke wrote:
> > > On Wed, 18 Jun 2014 11:12:43 -0700, Amitay Isaacs <amitay at gmail.com>
> > > wrote:
> > >
> > > > Here's the first draft of the migration from autoconf to waf build
> for CTDB.
> > > >
> > > > Currently, CTDB is configured and built separately from Samba
> (top-level
> > > > build).  The integration of build requires some more work on
> lib/util, so
> > > > it can be used in CTDB without bringing in too many samba
> dependencies.
> > > >
> > > > Since these changes drop duplicate libraries
> (talloc/tevent/tdb/replace), I
> > > > am not posting the patches on the mailing list.  The patches are
> available
> > > > in ctdb-build branch of my samba tree.
> > > >
> > > >
> > > >
> http://git.samba.org/?p=amitay/samba.git;a=shortlog;h=refs/heads/ctdb-build
> > >
> > > Looks good to me.  The only nit is that:
> > >
> > >     ctdb-mkversion: Support external VERSION specification
> > >
> > > should go before:
> > >
> > >     ctdb-build: Add waf build for CTDB
> > >
> > > Reviewed-by: Martin Schwenke <martin at meltin.net>
> > >
> > > However, I'm guessing that someone who knows waf should probably review
> > > too...  ;-)
> >
> > It is pretty good, the main comment I would make is not to do this:
> >
> > +    bld.SAMBA_SUBSYSTEM('ctdb-common',
> > +                        source=CTDB_COMMON_SRC,
> > +                        includes='include include/internal common .
> > lib/util',
> > +                        deps='replace popt talloc tevent tdb')
> > +
> >
> > but to instead list the source files in source=, unless there is a
> > specific reason not to.  We have been moving away from this style
> > elsewhere in the code-base.
>
> Also, here is one more duplicate file.
>
> Andrew Bartlett
>
>
Thanks Andrew.  I have updated the wscript file by removing the
intermediate variables.

Updated patches are in ctdb-build branch.


https://git.samba.org/?p=amitay/samba.git;a=shortlog;h=refs/heads/ctdb-build

Amitay.


More information about the samba-technical mailing list