[PATCHES] samba-tool: add --site parameter to provision command
kamenim at samba.org
Tue Jun 17 20:49:16 MDT 2014
Hi Bjoern, Michael,
I am very sorry, totally forgot about this.
Reviewed-by: Kamen Mazdrashki <kamenim at samba.org>
On Tue, Jun 17, 2014 at 9:51 AM, Michael Adam <obnox at samba.org> wrote:
> Reviewed-by: Michael Adam <obnox at samba.org>
> Kamen might have another look since you addressed
> some of his remarks.
> Cheers - Michael
> On 2014-06-10 at 16:45 +0200, Bjoern Baumbach wrote:
> > Hi Kamen,
> > thank you for the review and remarks.
> > On 06/10/2014 02:17 PM, Kamen Mazdrashki wrote:
> > > You are passing sitename directlly, and it is already guessed by
> > > guess_names().
> > > So, you should have exactly what you need names.sitename.
> > Great! So I use the names parameter :) I've fixed that for
> > setup_ad_dns(), too.
> > Please find the new patch attached.
> > > And then, following check is redundand:
> > > + if sitename is None:
> > > + sitename = DEFAULTSITE
> > ok.
> > > It seems to also, that after the 3-th patch we are going to end up with
> > > two consts for DEFAULTSITE
> > > One in .../provision/__init__.py and one in domain.py
> > > I hope I am not missreading the patch here
> > Yes, I know. But there was no technical problem with this second
> > definition (no collision/re-definition). I thought it's better than the
> > hard-coded strings deep in the functions :-)
> > Best regards
> > Björn
More information about the samba-technical