[PATCH] Fix SMB2 issues found by Microsoft plugfest test tool.

Ira Cooper ira at samba.org
Tue Jun 17 18:10:00 MDT 2014


Reviewed-by: Ira Cooper <ira at samba.org>

-Ira


On Tue, Jun 17, 2014 at 5:04 PM, Jeremy Allison <jra at samba.org> wrote:

> On Tue, Jun 17, 2014 at 03:53:17PM -0700, Jeremy Allison wrote:
> > On Tue, Jun 17, 2014 at 01:01:44PM -0700, Ira Cooper wrote:
> > > yay!
> > >
> > > Reviewed-by: Ira Cooper <ira at samba.org>
> >
> > sigh. Turns out that the test:
> >
> > ource4/torture/smb2/durable_open.c:597: Incorrect status
> > NT_STATUS_BAD_IMPERSONATION_LEVEL - should be NT_STATUS_OK
> >
> > shows we must only do the impersonation level
> > check on a *real* open, not on a durable handle
> > reopen, so move the check for invalid
> > impersonation level to the branch where
> > we're doing the real open.
> >
> > Now passes local make test :-).
> >
> > Updated patchset attached !
>
> And here is a new regression test patch
> that proves that a real open with an
> invalid impersonation level fails with
> NT_STATUS_BAD_IMPERSONATION_LEVEL :-).
>
> Please review !
>
> Jeremy.
>


More information about the samba-technical mailing list