Patch to handle sid compression for consideration ...

[Jeremy Allison]

On Tue, Jun 17, 2014 at 10:30:09AM -0400, Simo wrote:
> 
> I like your plan very much in general.
> 
> However I see that you repeat the same 3 calls in an "if (logon_info)"
> wrapped code block in 2 places. That calls for a utility function
> instead, or we risk someone changing it in one place but not another in
> the future. I would like something that does
> make_info3_from_pac() or similar that takes PAC_LOGON_INFO and returns
> netr_SamInfo3.
> 
> So then the common code becomes:
> if (logon_info) {
> 	status = make_info3_from_pac(tmp_ctx, logon_info, &info3);
> 	if (!NT_STATUS_IS_OK(status)) ...
> 	netsamlogon_cache_store(ntuser, info3);
> }
> 
> Alternatively:
> If (logon_info) {
> 	status = netsamlogon_cache_from_pac(logon_info);
> 	if (!NT_STATUS_IS_OK(status)) ...
> }
> 
> And just put all in this function.
> 
> Besides that it looks the right way to go.

Agreed - I'll update the patchset and
re-post.

Jeremy.