Patch to handle sid compression for consideration ...

Jeremy Allison jra at samba.org
Tue Jun 17 10:12:51 MDT 2014


On Tue, Jun 17, 2014 at 10:11:59AM +0200, Volker Lendecke wrote:
> On Mon, Jun 16, 2014 at 11:37:48PM -0700, Jeremy Allison wrote:
> > Ok, couldn't get to sleep :-). Here is the patchset.
> > Ended up being 5 patches.
> 
> Looks good to me, haven't tested it though yet.
> 
> > >From f3b61999b2886cff5077a318cfe19c95c52a9990 Mon Sep 17 00:00:00 2001
> > From: Jeremy Allison <jra at samba.org>
> > Date: Mon, 16 Jun 2014 23:11:58 -0700
> > Subject: [PATCH 3/5] s3: auth: Add merge_resource_sids() to merge resource
> >  group SIDs into an info3.
> > 
> > Originally written by Richard Sharpe Richard Sharpe <realrichardsharpe at gmail.com>.
> > 
> > Signed-off-by: Jeremy Allison <jra at samba.org>
> > ---
> >  source3/auth/proto.h       |  2 ++
> >  source3/auth/server_info.c | 52 ++++++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 54 insertions(+)
> > 
> > diff --git a/source3/auth/proto.h b/source3/auth/proto.h
> > index ab8fb89..b302b0e 100644
> > --- a/source3/auth/proto.h
> > +++ b/source3/auth/proto.h
> > @@ -294,6 +294,8 @@ NTSTATUS serverinfo_to_SamInfo3(const struct auth_serversupplied_info *server_in
> >  				struct netr_SamInfo3 *sam3);
> >  NTSTATUS serverinfo_to_SamInfo6(struct auth_serversupplied_info *server_info,
> >  				struct netr_SamInfo6 *sam6);
> > +NTSTATUS merge_resource_sids(struct PAC_LOGON_INFO *logon_info,
> > +				struct netr_SamInfo3 *info3);
> 
> Would a "const" on logon_info do here as well? This patchset
> already contains some const fixes :-)

Yep - I'll add that !


More information about the samba-technical mailing list