[PATCH] s4:dsdb/common: samdb_result_parameters: fix bug in ldb_val to lsa_BinaryString conversation

[Stefan Gohmann]

Hi Andrew,

Am 17.06.2014 06:10, schrieb Andrew Bartlett:
> On Mon, 2014-05-26 at 23:03 +0200, Stefan Gohmann wrote:
>> Hi Matthias,
>>
>> Am 26.05.2014 14:09, schrieb Matthias Dieter Wallnöfer:
>>> Hi Stefan,
>>>
>>> it seems that no other one responded. I think that this is rather a
>>> problem with the "userParameters" attribute which we still do not parse
>>> correctly I think.
>>
>> thanks. I've re-checked this issue.
>>
>> In my case the userParameters attribute is 105 bytes long. I think the
>> problem is that the length is odd and so there is one byte missing.
>>
>> I was able to reproduce this issue while setting userParameters for a
>> user to the following value:
>>
>> userParameters::
>> Q3R4Q2ZnUHJlc2VudCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUAIaCAFDdHhDZmdQcmVzZW5045S15pSx5oiw44GiGAgBQ3R4Q2ZnRmxhZ3Mx44Cw44Gm44Cy44C5
> 
> Where did you get this value from (what tool crated it?)
> 
> The reason I ask it that it does not start with the tell-tale 0x20 0x20
> 0x20 patterns at the start.

I'm not complete sure but I think at this time I had only the customer
system. So I think the value came from the customer system.

Previously the customer had a Windows small business server 2008. Samba
4 was joined into the Windows domain, everything was replicated from the
Windows server to the Samba 4 system (DRS + robocopy for sysvol) and the
Windows server was shut down.

I could try to reproduce it.

Thanks,
Stefan

-- 
Stefan Gohmann
Head of Software Engineering

Univention GmbH
be open.
Mary-Somerville-Str.1
28359 Bremen
Tel. : +49 421 22232-0
Fax :  +49 421 22232-99

gohmann at univention.de
http://www.univention.de

Geschäftsführer: Peter H. Ganten
HRB 20755 Amtsgericht Bremen
Steuer-Nr.: 71-597-02876