Patch to handle sid compression for consideration ...

Simo simo at
Mon Jun 16 08:56:01 MDT 2014

On Mon, 2014-06-16 at 07:45 -0700, Richard Sharpe wrote:
> Hi folks,
> Attached is a cleaned up patch to handle sid compression in master.
> I have implemented Volker's suggestion to not mess with SID internals
> and use compose_sid instead.
> I have also moved things around a bit to fit better into the existing
> code and not expose too many internal functions.
> Finally, I added a call to winbindd_pam where needed.
> This is a first pass at handling SID compression, and if we find we
> need to handle resource SIDs differently depending on which domain
> they are in, then the function merge_resource_sids_and_cache can
> absorb that code.
> Review please, and if acceptable, please push.

Wouldn't it be better to copy info3 first and then modify the copy ?


More information about the samba-technical mailing list