[PATCH] fix ctdb build with external tdb
jelmer at samba.org
Mon Jun 16 05:56:46 MDT 2014
On Mon, Jun 16, 2014 at 01:43:02PM +0200, Michael Adam wrote:
> On 2014-06-16 at 13:36 +0200, Jelmer Vernooij wrote:
> > On Mon, Jun 16, 2014 at 01:28:20PM +0200, Michael Adam wrote:
> > > Hi,
> > >
> > > attached patch fixes ctdb's build against external libtdb
> > > installed into a non-standard directory (like in autobuild).
> > >
> > > Might not be needed any more once we switch to waf, but
> > > while we don't have it yet...
> > Reviewed-By: me
> > It might also be simpler to use PKG_CONFIG_MODULES here, rather than checking for a specific function.
> Right. Might also be more robust.
> But the function check was already there,
> it was just not working 100% . And I wanted
> to do minimal change to the m4 file since
> Amitay is working on switching CTDB to waf.
Fair enough. I just wanted to mention it. I think the patch is fine as is as well (hence my review).
More information about the samba-technical