[PATCH] Rework base.delaywrite timing, make raw.mux use subunit properly.

[Andrew Bartlett]

I decided to look at our flapping tests, and see what I could do.  I
fixed up the raw.mux test to use subunit, and I also got sick of our
delay_write failures, so I reworked the test.

I know the code still isn't the most pretty, but I think the
functionality is a distinct improvement, and I have good reason to
expect it to be much more reliable.

See attached.

The code had some really weird timing stuff in it, and I've simplified
the logic to be clearly dependent on the writetimeupdatedelay
configuration variable.

Testing against Win2008R2, it 'fixes' (for some unknown reason):

time: 2014-06-16 16:14:49.421560
failure: delayed update of write time 3b [
Server updated write_time after 0.50 seconds (1sec == 0.50) (wrong!)
]

and this test still fails:

time: 2014-06-16 16:15:19.994883
failure: delayed update of write time 4 [
../source4/torture/basic/delaywrite.c:2305: wrong write_time (pinfo1)Mon
Jun 16 16:15:15 2014 NZST(130473657154738000) <= (pinfo0)Mon Jun 16
16:15:15 2014 NZST(130473657154738000)
]
(and on the new code)
time: 2014-06-16 16:09:36.057152
failure: delayed update of write time 4 [
../source4/torture/basic/delaywrite.c:2300: wrong write_time (pinfo1)Mon
Jun 16 15:09:07 2014 NZST(130473617468604000) <= (pinfo0)Mon Jun 16
15:09:07 2014 NZST(130473617468604000)
]

otherwise, the test is consistent as it was before my changes.

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba



-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-torture-convert-CHECK_STATUS-into-torture_assert_nts.patch
Type: text/x-patch
Size: 8805 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140616/1f871635/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-torture-convert-raw.mux-to-use-torture_assert-macros.patch
Type: text/x-patch
Size: 4634 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140616/1f871635/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-torture-convert-raw.mux-to-use-torture_comment-macro.patch
Type: text/x-patch
Size: 8863 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140616/1f871635/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-torture-Store-writetimeupdatedelay-in-a-double-to-al.patch
Type: text/x-patch
Size: 7971 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140616/1f871635/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-torture-Only-error-if-the-write-time-was-updated-is-.patch
Type: text/x-patch
Size: 5082 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140616/1f871635/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-torture-base.delaywrite-assert-the-for-a-delayed-wri.patch
Type: text/x-patch
Size: 5635 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140616/1f871635/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-selftest-Run-base.delaywrite-against-plugin_s4_dc-on.patch
Type: text/x-patch
Size: 4678 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140616/1f871635/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-torture-tidy-up-whitespace-for-clarity.patch
Type: text/x-patch
Size: 1294 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140616/1f871635/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-torture-Remove-confusing-reference-to-1-sec-0.25.patch
Type: text/x-patch
Size: 10026 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140616/1f871635/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140616/1f871635/attachment.pgp>