vfs_streams_xattr: stream name prefix and type suffix

[Ralph Böhme]

On Tue, Jun 10, 2014 at 12:19:41PM -0700, Christof Schmitt wrote:
> On Sun, Jun 01, 2014 at 05:42:16PM +0200, Ralph Böhme wrote:
> > Hi Christof
> > 
> > On Tue, May 27, 2014 at 02:41:37PM -0700, Christof Schmitt wrote:
> > > On Fri, May 23, 2014 at 06:52:05PM +0200, Volker Lendecke wrote:
> > > > On Wed, May 21, 2014 at 01:47:53PM +0200, Ralph Böhme wrote:
> > > > > With the patches applied, adding the following to smb.conf
> > > > > 
> > > > >       streams_xattr:prefix = user.
> > > > >       streams_xattr:store_stream_type = no
> > > > > 
> > > > > gives the desired behaviour.
> > > > > 
> > > > > Thoughts?
> > > > 
> > > > The idea sounds good.
> > > 
> > > source3/smbd/trans2.c
> > > 
> > > has this function that relies on the user.DosStream prefix to determine
> > > which xattrs to exclude from extended attributes returned to the client:
> > > 
> > > static bool samba_private_attr_name(const char *unix_ea_name)
> > > {
> > > ...
> > > }
> > 
> > that's exactly the function I'm making public in the first commit. :)
> > 
> > > Changing the prefix only for streams_xattr would make these attributes
> > > also visible to clients connecting to Samba. Maybe that is not a big
> > > issue, but we should be at least aware of it and put it in the
> > > documentation (manpage?).
> > 
> > Yup! I've added this to the manpage patch.
> > 
> > Patch series attached including the updated manpage patch 0003.
> 
> Thanks. The patches look good to me:
> Reviewed-by: Christof Schmitt <cs at samba.org>

Thanks! Can someone push it please?

-Ralph

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de,mailto:kontakt@sernet.de