[PATCH] Fix smbclient to use modern (trans2/SMB1) disk size calls.

Volker Lendecke Volker.Lendecke at SerNet.DE
Fri Jun 6 08:09:29 MDT 2014

On Thu, Jun 05, 2014 at 11:19:16AM -0700, Jeremy Allison wrote:
> Based on the request for Xerox, here is
> a short patchset to update smbclient to
> request disk sizes for SMB1 via a more
> modern trans2 call rather than the (now
> obsolete for EMC :-) core protocol call.
> Part #1: Create new 64-bit cli_disk_size() call.
> Initially based on top of the old cli_dskattr()
> call. Move the 2 users of cli_dskattr() to the
> new call.
> Part #2: Widen cli_smb2_dskattr() to a 64-bit
> interface (compatible with cli_disk_size()).
> Part #3: Change cli_disk_size() to call the
> existing cli_get_fs_full_size_info() call
> for SMB1 (use cli_smb2_dskattr() as before
> for SMB2) and only fall back to cli_dskattr()
> if cli_get_fs_full_size_info() is unsupported.
> As cli_get_fs_full_size_info() is used by
> libsmbclient() this is already safe to
> use.
> Please review and/or push !

Reviewed-by: me and pushed. If the autobuild breaks, feel 
free to retry with my rb.


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list