jelmer at samba.org
Thu Jun 5 16:42:55 MDT 2014
On Thu, Jun 05, 2014 at 06:12:35PM +0200, Andreas Schneider wrote:
> On Thursday 05 June 2014 16:44:36 Jelmer Vernooij wrote:
> > On Thu, Jun 05, 2014 at 04:35:13PM +0200, Michael Adam wrote:
> > > Ok, I reviewed that patch and let Andreas push it
> > > without going to the list, because I thought it
> > > would not disturb anybody.
> > >
> > > But I see that David's general concerns are justyfied to
> > > some extent, especially the bloating when many more files
> > > for various build environments would be added.
> > >
> > > Sorry to have created disturbance.
> > >
> > > I think samba has a history of adding small developer
> > > convenience thingies to the tree from time to time,
> > > e.g. "make ctags".
> > >
> > > What do others think: Should we allow this kind of
> > > convenience in the repo? Only in a special subdirectory?
> > > Or nos at all? I don't know.
> > In general, adding things like this don't seem particularly problematic.
> > They're making life more convenient for some folks and don't get in the
> > way.
> > That said, it is more harmful to have outdated files in the tree
> > than to not have them at all. How will the manual list of include
> > directories be kept up to date?
> I would normally update it as I use it on a daily bases. It would be easier if
> waf would be able to create a json compilation database.
> cmake has support for this by default. So if you work on cwrap, the file is
> generated by default.
> I have a ycm default config which looks for this database and uses it.
Does that mean a patch to this file every time we change our include
directories? That would be noisy.
A patch to waf that exports this database would be great.
Jelmer Vernooij <jelmer at samba.org> - http://samba.org/~jelmer/
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 819 bytes
Desc: Digital signature
More information about the samba-technical