[PATCH] Re: Help wanted on AD DC winbindd work

[Andrew Bartlett]

On Thu, 2014-06-05 at 14:43 +0200, Andreas Schneider wrote:
> On Wednesday 04 June 2014 22:35:07 Andrew Bartlett wrote:
> > On Tue, 2014-06-03 at 13:45 +0200, Andreas Schneider wrote:
> > > On Monday 26 May 2014 16:05:11 Andreas Schneider wrote:
> > > > > > Jeremy, I know how much you prefer attached patches, so here is the
> > > > > > set
> > > > > > I'm looking to get into master.
> > > > > > 
> > > > > > git://git.samba.org/abartlet.git ad-dc-winbindd-pre
> > > > > > https://git.samba.org/abartlet/samba.git/?p=abartlet/samba.git/.git;
> > > > > > a=sh
> > > > > > or
> > > > > > tlog;h=refs/heads/ad-dc-winbindd-pre
> > > > > > 
> > > > > > Please review/push
> > > > > 
> > > > > I updated the patches and branches, and they now pass a full
> > > > > autobuild.
> > > > 
> > > > I've started with a review of these patches.
> > > 
> > > Hi,
> > > 
> > > I've looked through the patches. What is marked with TODO needs some
> > > changes. Patches marked with REVIEW I need to look at them again. I
> > > haven't understood them in detail yet.
> > > 
> > > https://git.samba.org/?p=asn/samba.git;a=shortlog;h=refs/heads/REVIEW_ad-d
> > > c-winbindd-pre
> > I've fixed up the issues you raised, see
> > 
> > https://git.samba.org/abartlet/samba.git/?p=abartlet/samba.git/.git;a=shortl
> > og;h=refs/heads/asn-REVIEW_ad-dc-winbindd-pre-fixes
> > 
> > Hopefully this addresses your concerns.
> > 
> > Regarding:
> > https://git.samba.org/abartlet/samba.git/?p=abartlet/samba.git/.git;a=commit
> > diff;h=c5a662fe4e76917a040ff32eb9e5eec41537b5f0
> > 
> > This code order follows what metze has done for the SamLogon code, on
> > which it was based.
> > 
> > Andrew Bartlett
> 
> I've added more RB+ and updated the branch. I'm sorry but I'm not able to 
> finish the review. I'm leaving for vacation. Maybe someone else can jump in 
> and finish it:
> 
> https://git.samba.org/?p=asn/samba.git;a=shortlog;h=refs/heads/REVIEW_ad-dc-winbindd-pre
> 
> 
> 4 patches need review.

Thank you so much for the review, and for being proactive about passing
on the baton!

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba