[PATCH] librpc: Fix a "ignoring asprintf return" warning

Volker Lendecke Volker.Lendecke at SerNet.DE
Thu Jun 5 06:40:14 MDT 2014


Hi!

Review & push would be appreciated.

Thanks,

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
-------------- next part --------------
From 16bd94cbc04eea39bbb65cc84ef9de22045c636a Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl at samba.org>
Date: Thu, 5 Jun 2014 12:38:50 +0000
Subject: [PATCH] librpc: Fix a "ignoring asprintf return" warning

Signed-off-by: Volker Lendecke <vl at samba.org>
---
 source4/librpc/rpc/dcerpc_util.c |    9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/source4/librpc/rpc/dcerpc_util.c b/source4/librpc/rpc/dcerpc_util.c
index f87d8da..a9eaccb 100644
--- a/source4/librpc/rpc/dcerpc_util.c
+++ b/source4/librpc/rpc/dcerpc_util.c
@@ -798,10 +798,11 @@ _PUBLIC_ void dcerpc_log_packet(const char *lockdir,
 
 	for (i=0;i<num_examples;i++) {
 		char *name=NULL;
-		asprintf(&name, "%s/rpclog/%s-%u.%d.%s", 
-			 lockdir, ndr->name, opnum, i,
-			 (flags&NDR_IN)?"in":"out");
-		if (name == NULL) {
+		int ret;
+		ret = asprintf(&name, "%s/rpclog/%s-%u.%d.%s",
+			       lockdir, ndr->name, opnum, i,
+			       (flags&NDR_IN)?"in":"out");
+		if (ret == -1) {
 			return;
 		}
 		if (!file_exist(name)) {
-- 
1.7.9.5



More information about the samba-technical mailing list