[PATCH] Add back --with-fake-kaserver option to the build
abartlet at samba.org
Mon Jun 2 21:58:04 MDT 2014
On Mon, 2014-06-02 at 21:21 +0200, Christian Ambach wrote:
> Am 16.05.14 08:14, schrieb Volker Lendecke:
> > On Fri, May 16, 2014 at 07:58:56AM +1200, Andrew Bartlett wrote:
> >> Please ask Volker why the override is there, and get an explanation
> >> added, or remove it.
> > To be honest, I don't remember that aspect of the code.
> It seems that Volker had the same questions in mind when he wrote
> that code ten years ago. So he asked on the openafs mailinglist and
> the answer was that the ViceId can be to anything.
> This id is not used for access control, for that purpose the id in the
> ptserver is used. I performed some tests to verify that it really does
> not matter to which value the ViceId is set.
> I reworked the patchset again and replaced this chunk now
> with a call to geteuid(), as this might be useful for debugging a token.
> So the move of the util_sec code could be left out.
> Please give it another look.
Do we really need the <des.h> to "des.h" changes (I'm trying not to
churn the heimdal code for no reason).
If so, can you do that in distinct commit with a clear message?
Otherwise, it's fine, and reviewed-by: me.
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical