[PATCH] Merging loadparm further

Michael Adam obnox at samba.org
Thu Jul 31 00:21:12 MDT 2014

On 2014-07-31 at 14:48 +1200, Garming Sam wrote:
> Thanks a lot Michael.
> I've looked over the changes you've made and they all seemed pretty
> reasonable.

I pushed your patches to autobuild after rebasing my
two trivial add-on patches to the top.

Attached for further review.

One of them (remove unused lp_string_set) can only be
applied once your patches are in.

Cheers - Michael

> On 29/07/14 22:58, Michael Adam wrote:
> >Hi Garming,
> >
> >I am now done reviewing your patches.
> >Attached find my reviewed version. I:
> >- adapted a few commit messages
> >- fixed one formatting
> >- split one commit in 2
> >- replaced your comment fix by my comment removal
> >- added one loadparm patch on top
> >
> >I indicated in the commit message by "(OBNOX:...)" where I changed
> >something.
> >
> >I'm happy with thos changes pushed to master.
> >My two (trivial) patches would need a team-review.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140731/2cb96bad/attachment.pgp>

More information about the samba-technical mailing list