[PATCH] samba: Retain case sensitivity of cifs client

[Shirish Pargaonkar]

Bug 10755 has been added to the database

On Mon, Jul 28, 2014 at 6:19 PM, Jeremy Allison <jra at samba.org> wrote:
> On Sat, Jul 26, 2014 at 10:41:25AM -0500, shirishpargaonkar at gmail.com wrote:
>> From: Shirish Pargaonkar <spargaonkar at suse.com>
>>
>> When a client supports extended security but server does not,
>> and that client, in Flags2 field of smb header indicates that
>>
>> - it supports extended security negotiation
>> - it does not support security signatures
>> - it does not require security signatures
>>
>> Samba server treats a client as a Vista client.
>>
>> That turns off case sensitivity and that is a problem for cifs vfs client.
>>
>> So include remote cifs client along with remote samba client
>> to not do so otherwise.
>>
>> Signed-off-by: Shirish Pargaonkar <spargaonkar at suse.com>
>> ---
>>  source3/smbd/negprot.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/source3/smbd/negprot.c b/source3/smbd/negprot.c
>> index 4cd12d8..225fe39 100644
>> --- a/source3/smbd/negprot.c
>> +++ b/source3/smbd/negprot.c
>> @@ -262,7 +262,8 @@ static void reply_nt1(struct smb_request *req, uint16 choice)
>>       if ( (req->flags2 & FLAGS2_EXTENDED_SECURITY) &&
>>               ((req->flags2 & FLAGS2_SMB_SECURITY_SIGNATURES_REQUIRED) == 0) )
>>       {
>> -             if (get_remote_arch() != RA_SAMBA) {
>> +             if ((get_remote_arch() != RA_SAMBA) &&
>> +                             (get_remote_arch() != RA_CIFSFS)) {
>>                       set_remote_arch( RA_VISTA );
>>               }
>>       }
>> --
>> 1.8.3.2
>
> Reviewed-by: Jeremy Allison <jra at samba.org>
>
> Can I get a second Team reviewer please then
> I'll push ?
>
> Shirish, do we have a bug report for this as
> I think we need this in 4.1.x and 4.0.x as
> well.
>
> Cheers,
>
>         Jeremy