[PATCH] s4-dns: dlz-bind9: Continue lookup if error on multivalued record types

[Samuel Cabrero]

Here it is the fix for python samba.tests.dns and a patch to remove the 
zone cache in the dns server task. With this changes, all DNS tests are 
passing for me.

Samuel.

On 30/07/14 16:09, Samuel Cabrero wrote:
> Hi Amitay,
>
> I have made the test work, but I found another issue. The internal DNS
> server caches the zones when the task start so if a new zone is added it
> is not aware of it until samba restarts. All queries for that zone are
> forwarded or fail with NXDOMAIN.
>
> I see two options here:
> 1. Do not cache the zones and behave like the bind dlz, querying the
> database in each DNS query.
> 2. Implement IRPC handlers in dns server for zone created/deleted, and
> call them whenever a zone is created or deleted through RPC to reload
> cached zones.
>
> Which one do you think is better?
>
> Samuel.
>
> On 29/07/14 10:56, Amitay Isaacs wrote:
>> On Thu, Jul 24, 2014 at 6:15 PM, Samuel Cabrero <scabrero at zentyal.com
>> <mailto:scabrero at zentyal.com>> wrote:
>>
>>     Hi Amitay,
>>
>>     I have reformatted the patches following your hints, extended the
>>     internal dns server tests to query for SOA and added the same test
>>     for the bind dlz (the internal DNS server was not affected by the
>>     issue, anyway I have written tests for both).
>>
>>     Samuel.
>>
>>
>> The patches look good now.  However the tests are failing.  Have you
>> tried running the tests?
>>
>>    make test TESTS=samba.tests.dns
>>
>> Your test is a bit tricky since it uses both RPC dnsserver interface and
>> DNS interface.   You will have to inherit from both DNSTest and
>> RpcInterfaceTestCase.  Then you automatically get the functions
>> get_loadparm() and get_credentials().  You don't need to define your own.
>>
>> Let me know if you are not able to make the test work.
>>
>> Amitay.
>

-- 
Samuel Cabrero - Developer
scabrero at zentyal.com

Zentyal - Active Exchange
www.zentyal.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-dns-Fix-credentials-used-in-test-for-WINS-and-WINS-R.patch
Type: text/x-patch
Size: 968 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140730/6cb355d9/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-s4-dns-Do-not-cache-zones-at-task-startup.patch
Type: text/x-patch
Size: 12455 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140730/6cb355d9/attachment-0001.bin>