[PATCH] s4-dns: dlz-bind9: Continue lookup if error on multivalued record types
amitay at gmail.com
Tue Jul 29 02:56:40 MDT 2014
On Thu, Jul 24, 2014 at 6:15 PM, Samuel Cabrero <scabrero at zentyal.com>
> Hi Amitay,
> I have reformatted the patches following your hints, extended the internal
> dns server tests to query for SOA and added the same test for the bind dlz
> (the internal DNS server was not affected by the issue, anyway I have
> written tests for both).
The patches look good now. However the tests are failing. Have you tried
running the tests?
make test TESTS=samba.tests.dns
Your test is a bit tricky since it uses both RPC dnsserver interface and
DNS interface. You will have to inherit from both DNSTest and
RpcInterfaceTestCase. Then you automatically get the functions
get_loadparm() and get_credentials(). You don't need to define your own.
Let me know if you are not able to make the test work.
More information about the samba-technical