[PATCH] Merging loadparm further
Jeremy Allison
jra at samba.org
Fri Jul 25 18:01:38 MDT 2014
On Fri, Jul 25, 2014 at 02:33:41PM +1200, Garming Sam wrote:
> Hi there,
>
> I've run these patches through the usual tests and made sure each
> patch passes the main tests we identified. It also passes the full
> autobuild with the winbindd patches in my other mail.
>
> This set of patches actually makes some good progress in merging the
> two codebases. I managed to remove a reasonable chunk of code.
>
> lib/param/loadparm.c | 239 ++++++++++++++++++++++++++----------
> lib/param/loadparm.h | 1 -
> lib/param/s3_param.h | 5 -
> source3/param/loadparm.c | 414
> +++++++++-----------------------------------------------------
> source3/param/loadparm_ctx.c | 5 -
> 5 files changed, 235 insertions(+), 429 deletions(-)
>
>
> Changes from now on should hopefully be quite a bit easier than it
> was back when I started.
>
> In particular, performing a 'do_parameter' is now equivalent and
> setting defaults could be done from the same code.
>
> A review would be appreciated.
>
>
>
> Cheers,
>
>
> Garming Sam
Garming, thanks for your continuing work on this !
I will try and make time next week to review this
patchset for you.
Cheers,
Jeremy.
More information about the samba-technical
mailing list