[PATCH v4] New VFS module vfs_fruit
Jeremy Allison
jra at samba.org
Fri Jul 25 11:22:27 MDT 2014
On Fri, Jul 25, 2014 at 04:30:10PM +0200, Ralph Böhme wrote:
> On Wed, Jul 23, 2014 at 01:55:33PM -0700, Jeremy Allison wrote:
> > On Thu, Jul 17, 2014 at 12:08:42PM +0200, Ralph Böhme wrote:
> > > updated patch series attached incorporating two fixes from Jeremy and
> > > a new test.
> > >
> > > Review appreciated!
> >
> > Just wanted to let you know I'm still looking at this.
> >
> > I'm trying to convince myself that ad_unpack() is
> > safe, secure code :-).
>
> woa, it's unsafe and 20 years old code, the first commit trackable via
> a VCS is from 2000:
>
> <https://github.com/Netatalk/Netatalk/blob/31843674b7bd32eabcce3a1ad6159b4f94921f79/libatalk/adouble/ad_open.c#L291>
>
> ;)
>
> > I'm sure it *probably* is, but it's taking me a while...
> >
> > Maybe some more comments would help ? :-).
>
> Maybe it's time to give it some love, ie buffer checks and bells and
> whistles. :)
>
> I'll post an Updated patchset in the next days.
Thanks Ralph. I really want to get this code in,
so I'll review whatever you come up with. Thanks
a *LOT* for your patience in working with me on
this.
Our Apple users will be much happier once we've
got this in :-).
Cheers,
Jeremy.
More information about the samba-technical
mailing list