[PATCH] selftest: Reduce waiting time for nmbd!

Andreas Schneider asn at samba.org
Fri Jul 25 08:48:55 MDT 2014

On Wednesday 23 July 2014 15:09:20 Michael Adam wrote:
> Hi!
> two comments:
> 1. nmblookup3 is binary-mapped to nmblookup,
>    so these commands are executed and can fail.
>    I guess we can remove the old name and use
>    nmblookup, but that should be a separate patch,
>    imho.
> 2. Other than that it is a good thing to reduce
>    the startup time for the environment.
>    I just want to point out that the current checks
>    don't only check whether nmblookup is running
>    but that it answeres a couple of requests.
>    And it may take nmbd a certain startup time
>    to be able to answer these.
>    So the patch does make a difference, but it may
>    well be enought to test only one request successfully.
>    But imho this change should be made more explicit in the
>    commit message.


Here is the same splitted in two patches with the additional queries still 
being executed after the first one succeeded.


	-- andreas

Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org

More information about the samba-technical mailing list