[PATCH v4] New VFS module vfs_fruit

Ralph Böhme rb at sernet.de
Fri Jul 25 08:30:10 MDT 2014

On Wed, Jul 23, 2014 at 01:55:33PM -0700, Jeremy Allison wrote:
> On Thu, Jul 17, 2014 at 12:08:42PM +0200, Ralph Böhme wrote:
> > updated patch series attached incorporating two fixes from Jeremy and
> > a new test.
> > 
> > Review appreciated!
> Just wanted to let you know I'm still looking at this.
> I'm trying to convince myself that ad_unpack() is
> safe, secure code :-).

woa, it's unsafe and 20 years old code, the first commit trackable via
a VCS is from 2000:



> I'm sure it *probably* is, but it's taking me a while...
> Maybe some more comments would help ? :-).

Maybe it's time to give it some love, ie buffer checks and bells and
whistles. :)

I'll post an Updated patchset in the next days.

Thanks for your help!

SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen

More information about the samba-technical mailing list