[PATCHES] s3-winbind-idmap initialization fixes / improvements

Michael Adam obnox at samba.org
Fri Jul 25 08:02:07 MDT 2014

On 2014-07-25 at 11:53 +0200, Volker Lendecke wrote:
> On Wed, Jul 23, 2014 at 11:53:49AM +0200, Michael Adam wrote:
> > attached find a few patches that improve idmap_init_domain().
> > 
> > The first one is a fix for bug #10737 which I just created:
> > It prevents a very misleading log message at level 1 in 
> > the case where idmap_init_domain() is called from
> > idmap_passdb_domain().
> > 
> > review/push/comments appreciated.
> Pushed.


> Question: Shouldn't we refactor idmap_init_domain a bit by
> taking out the range checks into a separate routine?
> Alternatively, for "check_range==false" just ignore the
> range completely,

I thought about going into that direction,
but wanted to do less invasive cleanups first.
And I am glad the discussion starts. :-)

> or even give an error if a range is given for passdb?

That sounds like an interesting option, too.

> The lines after "if (range == NULL) {" are
> pretty confusing, to me it seems that we only really do
> stuff if check_range is true.

That is true.
Since the variant with range_check == false is (currently)
only used for passdb, I think would favour the refactoring.

Will see if I can put something together.

Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140725/78d12a18/attachment.pgp>

More information about the samba-technical mailing list