[PATCHES] s3-winbind-idmap initialization fixes / improvements

Volker Lendecke Volker.Lendecke at SerNet.DE
Fri Jul 25 03:53:21 MDT 2014

On Wed, Jul 23, 2014 at 11:53:49AM +0200, Michael Adam wrote:
> attached find a few patches that improve idmap_init_domain().
> The first one is a fix for bug #10737 which I just created:
> It prevents a very misleading log message at level 1 in 
> the case where idmap_init_domain() is called from
> idmap_passdb_domain().
> review/push/comments appreciated.


Question: Shouldn't we refactor idmap_init_domain a bit by
taking out the range checks into a separate routine?
Alternatively, for "check_range==false" just ignore the
range completely, or even give an error if a range is given
for passdb? The lines after "if (range == NULL) {" are
pretty confusing, to me it seems that we only really do
stuff if check_range is true.


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list