[PATCH] s4-dns: dlz-bind9: Continue lookup if error on multivalued record types

Samuel Cabrero scabrero at zentyal.com
Thu Jul 24 02:15:39 MDT 2014


Hi Amitay,

I have reformatted the patches following your hints, extended the 
internal dns server tests to query for SOA and added the same test for 
the bind dlz (the internal DNS server was not affected by the issue, 
anyway I have written tests for both).

Samuel.

On 23/07/14 06:32, Amitay Isaacs wrote:
> On Mon, Jul 21, 2014 at 8:59 PM, Kamen Mazdrashki <kamenim at samba.org
> <mailto:kamenim at samba.org>> wrote:
>
>
>
>
>     On Wed, Jul 16, 2014 at 7:11 PM, Samuel Cabrero
>     <scabrero at zentyal.com <mailto:scabrero at zentyal.com>> wrote:
>
>         Hi,
>
>         I have finished with the WINS and WINS-R record support for the
>         internal DNS server, including the RPC interface, regular DNS
>         queries and tests for both of them. Please let me know if there
>         is something wrong with it.
>
>     Looks good to me.
>     Reviewed-by: Kamen Mazdrashki <kamenim at samba.org
>     <mailto:kamenim at samba.org>>
>
>     Kai, Amitay, could you please take look at patches if they are OK?
>
>     Regards,
>     Kamen
>
>
> Hi Samuel,
>
> Thanks for the implementation of wins records in DNS.  It's looking
> good.  However there seems to be some confusion regarding multiple dns
> related idl files. :-)
>
> Currently we do have some duplication of DNS structures.  Here is an
> explanation for where idl files are used.
>
>     dnsp.idl         - original partial implementation of MS_DNSP with
> focus only on resource records.  This is used in python scripts.
>     dns.idl           - DNS server implementation (using auto-generated
> marshaling routines)
>     dnsserver.idl   - RPC dns server
>
> You might be able to adjust your patches better with this explanation.
> I have included comments on patches for clarity.
>
>
> 4. idl: dnsp: Add dnsp_wins and dnsp_winsr data types for WINS and WINSR
> records
>
> Either include all idl changes in a single patch, or keep the changes in
> IDL and related code in a single patch.  So dnsp.idl changes should go
> with netcmd/dns.py changes.
>
> 5. s4-dns: Support WINS and WINS-R records queries over RPC
>
> This patch should only include dnsserver.idl and not dns.idl.  You might
> want to keep the code changes in rpc_server/dnsserver/dns_data.c with this.
>
> 6. s4-dns: Support WINS and WINS-R dns queries
>
> This patch should include changes to dns.idl
>
> 7. s4-rpc: dnsserver: Support WINS and WINS-R records
>
> As I mentioned previously, dnsserver.idl changes can be combined with
> this one.
>
> 8. dns: Extend tests for WINS and WINS-R records
>
> The tests are explicitly querying for WINS records, but are not querying
> for SOA records in presence of WINS records.  As I understood, that is
> the scenario which was not working.  We should also add a test that
> fails with current code, but works with your fixes.
>
> Also, you are missing the implementation of netcmd.dns.WINSRecord and
> netcmd.dns.WINSRRecord classes.  May be you forgot to include that patch?
>
> Amitay.
>

-- 
Samuel Cabrero - Developer
scabrero at zentyal.com

Zentyal - Active Exchange
www.zentyal.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-dns-Extend-bind-dlz-tests-to-query-SOA-in-zones-having-WINS-record.patch
Type: text/x-patch
Size: 6225 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140724/d4d7a01e/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-dns-Extend-tests-for-WINS-and-WINS-R-records.patch
Type: text/x-patch
Size: 8565 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140724/d4d7a01e/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-s4-dns-Support-WINS-and-WINS-R-dns-queries.patch
Type: text/x-patch
Size: 3322 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140724/d4d7a01e/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-s4-dns-Support-WINS-and-WINS-R-records-queries-over-RPC.patch
Type: text/x-patch
Size: 5615 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140724/d4d7a01e/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-dns.py-Support-WINS-and-WINS-R-records-queries-over-RPC.patch
Type: text/x-patch
Size: 10968 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140724/d4d7a01e/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-s4-dns-dlz-bind9-Return-success-only-if-at-least-one-record-sent.patch
Type: text/x-patch
Size: 1293 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140724/d4d7a01e/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-s4-dns-dlz-bind9-Fix-talloc-contexts-not-freed.patch
Type: text/x-patch
Size: 1575 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140724/d4d7a01e/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s4-dns-dlz-bind9-Continue-lookup-if-error-on-multivalued-record-types.patch
Type: text/x-patch
Size: 1451 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140724/d4d7a01e/attachment-0007.bin>


More information about the samba-technical mailing list